Remove the in-progress cache #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest history commitment provider implementation is more efficient and we no longer need the cache to optimize it. Fixes NIT-2324
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 60.09% 59.54% -0.56%
==========================================
Files 50 49 -1
Lines 8759 8713 -46
==========================================
- Hits 5264 5188 -76
- Misses 3488 3518 +30
Partials 7 7 |
eljobe
added a commit
that referenced
this pull request
Sep 17, 2024
This will cause us to deliberately decide if we need to increase the test size if they get bigger. It also prevents a warning in the output of `bazel test //...` Intentionally ignoring the in-progress cache as it is going away in #689
rauljordan
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest history commitment provider implementation is more
efficient and we no longer need the cache to optimize it.
Fixes NIT-2324