First pass API for introspection of edges and assertions #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and not just testing the handler in isolation
rauljordan
reviewed
Jul 21, 2023
rauljordan
reviewed
Jul 24, 2023
Comment on lines
+31
to
+34
|
|
||
| // Validator's point of view | ||
| // IsHonest bool `json:"isHonest"` | ||
| // AgreesWithStartCommitment `json:"agreesWithStartCommitment"` |
There was a problem hiding this comment.
Suggested change
| // Validator's point of view | |
| // IsHonest bool `json:"isHonest"` | |
| // AgreesWithStartCommitment `json:"agreesWithStartCommitment"` |
rauljordan
reviewed
Jul 24, 2023
| EndCommitment: toCommitment(e.EndCommitment), | ||
| MutualID: common.Hash(e.MutualId()), | ||
| OriginID: common.Hash(e.OriginId()), | ||
| ClaimID: func() common.Hash { |
There was a problem hiding this comment.
This pattern is so neat
rauljordan
reviewed
Jul 24, 2023
| EndHeight: e.EndCommitment.Height, | ||
| EndCommit: mock.Commit(e.EndCommitment.Hash.Bytes()), | ||
| OriginID: mock.OriginId(e.OriginID.Bytes()), | ||
| ClaimID: string(e.ClaimID.Bytes()), |
There was a problem hiding this comment.
There's a .String() method on hashes too
There was a problem hiding this comment.
Yes, but that returns it in the hex string form where we need it to be back in the original form
rauljordan
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on adding API endpoints that would be useful for introspection into the validator and the current edges or challenges.
Work-in-progress and looking for early review.
Current progress:
Future work: