Fix Up Assertion Creation Logic #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Jul 10, 2023
| return nil, errors.New("prev assertion creation info inbox max count not a uint64") | ||
| } | ||
| prevCreationInfo, err := a.ReadAssertionCreationInfo(ctx, protocol.AssertionHash(assertionCreationInfo.ParentAssertionHash)) | ||
| newOpts := copyTxOpts(a.txOpts) | ||
| newOpts.Value = parentAssertionCreationInfo.RequiredStake |
There was a problem hiding this comment.
What would happen if the dao were decide to raise the deposit stake? Shouldn't the stake be part of the config instead?
There was a problem hiding this comment.
It needs to come from the parent assertion info, which is data onchain, so we should be OK here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up our assertion creation logic, which was completely broken. Because our tests do not use a real, Nitro validator, our tests do not fail for assertion validity. Instead, we make sure: