feat: fetchDepositsByParentTxHashFromEventLog #2175
+387
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrstph-dvx
reviewed
Jan 13, 2025
| parentChainId: number | ||
| ): Promise<ParentTransactionReceipt | undefined> { | ||
| try { | ||
| const parentProvider = getProviderForChainId(Number(parentChainId)) |
There was a problem hiding this comment.
parentChainId should already be a number according to type on L28. If we expect to receive other type, we should update L28. Otherwise we can remove the casting here.
Comment on lines
85
to
91
| const parentToChildMessagesClassic = isClassic | ||
| ? await parentTxReceipt.getParentToChildMessagesClassic(childProvider) | ||
| : ([] as ParentToChildMessageReaderClassic[]) | ||
|
|
||
| const parentToChildMessages = isClassic | ||
| ? ([] as ParentToChildMessageReader[]) | ||
| : await parentTxReceipt.getParentToChildMessages(childProvider) |
There was a problem hiding this comment.
We can run those 2 queries in parallel with Promise.all
There was a problem hiding this comment.
We can also add the third one below on L93
Comment on lines
57
to
59
| expect(result.tokenDepositRetryables).toEqual( | ||
| expect.arrayContaining([ | ||
| expect.objectContaining({ |
There was a problem hiding this comment.
you can call directly expect(result.tokenDepositRetryables).toEqual([{...}]
…ntTxHashFromEventLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this PR only supports post-nitro txs
it covers all Orbit chains' use case as they have never used classic
Closes FS-1088