feat: check custom gateway tokens withdrawal approval #2144
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
changed the title
There was a problem hiding this comment.
Tested that after removal, the approval dialog still shows up for withdrawals with https://sepolia.arbiscan.io/token/0xdEFB0b365C718D1F9677E6232494B927c91284B6 (an xErc20 token on Sepolia)
| * Most tokens inherently allows the token gateway to burn whichever amount | ||
| * on the child chain for withdrawal because they inherited the | ||
| * IArbToken interface that allows the gateway to burn without allowance approval |
There was a problem hiding this comment.
| * Most tokens inherently allows the token gateway to burn whichever amount | |
| * on the child chain for withdrawal because they inherited the | |
| * IArbToken interface that allows the gateway to burn without allowance approval | |
| * Most tokens inherently allow the token gateway to burn the withdrawal amount | |
| * on the child chain because they inherit the | |
| * IArbToken interface that allows the gateway to burn without allowance approval |
|
|
||
| return allowance.lt(amount) | ||
| // tokens that use the standard gateways do not require approval on child chain | ||
| const standardGateways = [ |
There was a problem hiding this comment.
Can we simply check if the token contract has a valid and working bridgeBurn method to validate the same without needing to fetch the gateway address and checking standardGatways and introducing isError in gas estimation?
There was a problem hiding this comment.
we need the gateway address for getting allowanceForSourceChainGateway anyway
we can do an eth_call (provider.call) to check if the bridgeBurn method reverts with a message (means the method exists), but if the token contract implemented the method to revert without a message, then we might wrongly think that the method doesn't exist when it does
This covers USDC custom custom gateway (USDC bridge) but also other custom & custom custom gateway tokens.
This PR removes the hardcoded list we maintained for tokens that require approval at withdrawal.
Closes FS-973