feat: allow scw to change destination chain #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
commented
Dec 13, 2024
packages/arb-token-bridge-ui/src/components/TransferPanel/AdvancedSettings.tsx
Outdated
Show resolved
Hide resolved
dewanshparashar
previously approved these changes
Dec 24, 2024
dewanshparashar
previously approved these changes
Jan 2, 2025
brtkx
reviewed
Jan 8, 2025
| @@ -113,6 +117,7 @@ export const AdvancedSettings = () => { | |||
| ) | |||
| }, [ | |||
| initialDestinationAddressFromQueryParams, | |||
| isLoadingAccountType, | |||
There was a problem hiding this comment.
This is not used in this useEffect hook, why is it added?
There was a problem hiding this comment.
i used it in some commits but deleted the lines and forgot to remove it from the dependency array~ thanks!
dewanshparashar
previously approved these changes
Jan 8, 2025
spsjvc
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-993