Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds rollup data fetching from Orbit template #1981

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: adds rollup data fetching from Orbit template #1981

wants to merge 9 commits into from
+172 −255

Conversation

douglance
Copy link
Contributor

Summary

Steps to test

@douglance douglance requested a review from brtkx October 9, 2024 16:53
@cla-bot cla-bot bot added the cla-signed label Oct 9, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-token-bridge ✅ Ready (Inspect) Visit Preview Oct 14, 2024 6:13pm

@douglance douglance changed the title feat: adds rollup data fetching to simplify Orbit template feat: adds rollup data fetching from Orbit template Oct 9, 2024
fionnachan
fionnachan requested changes Oct 14, 2024
View reviewed changes
packages/scripts/src/addOrbitChain/network.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arb sdk has a method called getArbitrumNetworkInformationFromRollup that gives all these info

https://github.com/OffchainLabs/arbitrum-sdk/blob/792a7ee3ccf09842653bc49b771671706894cbb4/src/lib/dataEntities/networks.ts#L363

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing that out! we're now using that function 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fionnachan fionnachan fionnachan requested changes

@brtkx brtkx Awaiting requested review from brtkx

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglance @fionnachan