Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Readme #546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: Readme #546

wants to merge 2 commits into from

Conversation

Olexandr88
Copy link

Hello. Added a link to npm that was missing and changed documentation links that were broken

Copy link

cla-bot bot commented Nov 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

@hkalodner
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2024
Copy link

cla-bot bot commented Nov 1, 2024

The cla-bot has been summoned, and re-checked this pull request!

1 similar comment
Copy link

cla-bot bot commented Nov 19, 2024

The cla-bot has been summoned, and re-checked this pull request!

@@ -83,11 +83,11 @@ async function bridgeEth(parentSigner: ethers.Signer, childChainId: number) {
}
```

For more detailed usage examples and API references, please refer to the [Arbitrum SDK documentation](https://docs.arbitrum.io/sdk).
For more detailed usage examples and API references, please refer to the [Arbitrum SDK documentation](https://docs.arbitrum.io/welcome/get-started).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more detailed usage examples and API references, please refer to the [Arbitrum SDK documentation](https://docs.arbitrum.io/welcome/get-started).
For more detailed usage examples and API references, please refer to the [Arbitrum SDK documentation](https://docs.arbitrum.io/sdk/introduction).


## Running Integration Tests

1. Set up a Nitro test node by following the instructions [here](https://docs.arbitrum.io/node-running/how-tos/local-dev-node).
1. Set up a Nitro test node by following the instructions [here](https://docs.arbitrum.io/build-decentralized-apps/public-chains#nitro).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Set up a Nitro test node by following the instructions [here](https://docs.arbitrum.io/build-decentralized-apps/public-chains#nitro).
1. Set up a Nitro test node by following the instructions [here](https://docs.arbitrum.io/run-arbitrum-node/run-nitro-dev-node).

@@ -103,7 +103,7 @@ For more detailed usage examples and API references, please refer to the [Arbitr

## Documentation

For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/sdk).
For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/welcome/get-started).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/welcome/get-started).
For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/sdk/introduction).

@@ -103,7 +103,7 @@ For more detailed usage examples and API references, please refer to the [Arbitr

## Documentation

For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/sdk).
For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/welcome/get-started).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/welcome/get-started).
For comprehensive guides and API documentation, visit the [Arbitrum SDK Documentation](https://docs.arbitrum.io/sdk/introduction).

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ douglance
❌ Olexandr88
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants