Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create assembleChildTx to abstract away signing logic in an attempt to better support browser wallets #526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matzapata
Copy link

Extracted the assembling logic for signingChildTx away into it's separate function to better support browser wallets.

Metamask and other wallets currently don't support signing without sending (issue) and so signChildTx is impossible without users exporting private keys.

This Pr basically renames signChildTx to assembleChildTx removing the final line so the decision of only signing or signing and sending moves back to the developer integrating the SDK. I understand just signing is what makes the most sense but I believe sending doesn't make any harm and allows these extra cases.

Copy link

cla-bot bot commented Aug 2, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

Copy link

@Flisflas69 Flisflas69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link

@Flisflas69 Flisflas69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants