Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more informative gas estimator error #418

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+26 −8
Open

more informative gas estimator error #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da14982
more informative gas estimator error
godzillaba Mar 1, 2024
d605eeb
try catch in parse error
godzillaba Mar 1, 2024
67ab734
audit
godzillaba Mar 1, 2024
f55000c
use release nitro-testnode
godzillaba Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ jobs:
- name: Set up the local node
uses: OffchainLabs/actions/run-nitro-test-node@main
with:
nitro-testnode-ref: master
nitro-testnode-ref: release
l3-node: ${{ matrix.orbit-test == '1' }}
args: ${{ matrix.custom-fee == '1' && '--l3-fee-token' || '' }}

Expand Down
15 changes: 14 additions & 1 deletion audit-ci.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@
// we don't use oz/merkle-trees anywhere
// from @arbitrum/nitro-contracts>@offchainlabs/upgrade-executor>@openzeppelin/contracts-upgradeable
// from @arbitrum/nitro-contracts>@offchainlabs/upgrade-executor>@openzeppelin/contracts
"GHSA-wprv-93r4-jj2p"
"GHSA-wprv-93r4-jj2p",
// https://github.com/advisories/GHSA-9vx6-7xxf-x967
// OpenZeppelin Contracts base64 encoding may read from potentially dirty memory
// from: @arbitrum/nitro-contracts>@offchainlabs/upgrade-executor>@openzeppelin/contracts-upgradeable
// from: @arbitrum/token-bridge-contracts>@arbitrum/nitro-contracts>@offchainlabs/upgrade-executor>@openzeppelin/contracts-upgradeable
// from: @arbitrum/nitro-contracts>@openzeppelin/contracts-upgradeable
// from: @arbitrum/token-bridge-contracts>@arbitrum/nitro-contracts>@openzeppelin/contracts-upgradeable
// from: @arbitrum/token-bridge-contracts>@openzeppelin/contracts-upgradeable
// from: @arbitrum/nitro-contracts>@offchainlabs/upgrade-executor>@openzeppelin/contracts
// from: @arbitrum/token-bridge-contracts>@arbitrum/nitro-contracts>@offchainlabs/upgrade-executor>@openzeppelin/contracts
// from: @arbitrum/nitro-contracts>@openzeppelin/contracts
// from: @arbitrum/token-bridge-contracts>@arbitrum/nitro-contracts>@openzeppelin/contracts
// from: @arbitrum/token-bridge-contracts>@openzeppelin/contracts
"GHSA-9vx6-7xxf-x967"
]
}
17 changes: 11 additions & 6 deletions src/lib/dataEntities/retryableData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,16 @@ export class RetryableDataTools {
public static tryParseError(
ethersJsErrorOrData: Error | { errorData: string } | string
): RetryableData | null {
const errorData =
typeof ethersJsErrorOrData === 'string'
? ethersJsErrorOrData
: this.tryGetErrorData(ethersJsErrorOrData)
if (!errorData) return null
return errorInterface.parseError(errorData).args as unknown as RetryableData
try {
const errorData =
typeof ethersJsErrorOrData === 'string'
? ethersJsErrorOrData
: this.tryGetErrorData(ethersJsErrorOrData)
if (!errorData) return null
return errorInterface.parseError(errorData)
.args as unknown as RetryableData
} catch {
return null
}
}
}
Loading