Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom events #683

Merged
merged 26 commits into from
Oct 19, 2023
Merged

Add custom events #683

merged 26 commits into from
Oct 19, 2023

Conversation

Jason-W123
Copy link
Contributor

We provide customize precompile methods and contracts last time. Thanks to the suggestion and the solution of @hkalodner, we can also add customize event also.

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview Oct 19, 2023 3:11pm

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

Copy link
Contributor

@mahsamoosavi mahsamoosavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is 🔥

cast send 0x0000000000000000000000000000000000000064 "sayHi()(string)"
```

Then we will have a transaction hash result, call `eth_getTransactionReceipt` with that transaction hash, you may get:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then we will have a transaction hash result, call `eth_getTransactionReceipt` with that transaction hash, you may get:
Then you will have a transaction hash result. Calling`eth_getTransactionReceipt` with the transaction hash will give you the following:

Copy link
Contributor

@symbolpunk symbolpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misc nits, cc @TucksonDev @mahsamoosavi for a spot-check 🙏

@mahsamoosavi
Copy link
Contributor

Misc nits, cc @TucksonDev @mahsamoosavi for a spot-check 🙏

@Jason-W123 You can essentially disregard my comments, as they all duplicate @symbolpunk's comments.

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

2 similar comments
@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

@github-actions
Copy link

Hey there!
It looks like your changes are not well formatted. You can merge this PR, but we recommend to format your code with:

cd website && yarn format

Thanks!💙🧡

@Jason-W123
Copy link
Contributor Author

Thank you @mahsamoosavi and @symbolpunk !

Copy link
Contributor

@TucksonDev TucksonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a a few small non-blocking comment, but other than that LGTM!

@symbolpunk symbolpunk merged commit f7f23c4 into master Oct 19, 2023
2 checks passed
@symbolpunk symbolpunk deleted the add-custom-events branch October 19, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants