Allow templating of jails/actions/filters #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows templating of the jails etc by running the files through the Joinja2 templating engine. By this, local variables can directly be used in a jail, e.g.
my_data_dir = "/home/data"in the jail:
[myjail] backend = auto enabled = true port = 80,443 protocol = tcp filter = myfilter logpath = {{ my_data_dir }}/the.logFurthermore, the new configuration parameters are lists of templates - which means not all jails/filters end up on all target hosts, but the inventory can be used to set specific jails/filters for specific target machines.
This currently breaks backwards compatibility - if this is of concern I can add the old behavior back in addition to the feature here.