Add workflow to prevent additions to the Terraform SDK folder #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👍 Looks good. Sorry would this action failing prevent branch from merging? |
denys-octopus
approved these changes
Dec 12, 2024
Not 100% sure how GHA works in this sense. I don't think so, I think you need to specifically mark a workflow as "required" in GH before it'll block merges. |
|
Yep. We can choose to configure this as a blocking workflow if we want: |
|
Might keep it optional for a few PRs to ensure it works well, and think about adding it as mandatory in 2025. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly self-explanatory. Detects additions only, allows deletions and modifications.
Example successful run:
Example failed run:
