Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Git trigger functionality #835

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Add Git trigger functionality #835

merged 1 commit into from
Dec 9, 2024

Conversation

lourens-octopus
Copy link
Contributor

Add ability to create, read, update and delete Git Triggers

@lourens-octopus lourens-octopus force-pushed the lourens/git-trigger branch 30 times, most recently from d0d3a82 to b5bbbbf Compare December 8, 2024 21:18
@lourens-octopus lourens-octopus force-pushed the lourens/git-trigger branch 8 times, most recently from a42669e to 15fec7e Compare December 9, 2024 02:24
@lourens-octopus lourens-octopus requested review from a team December 9, 2024 02:54
geofflamrock
geofflamrock approved these changes Dec 9, 2024
View reviewed changes
Copy link

@geofflamrock geofflamrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a Git triggers point of view this looks good, thanks for your efforts in tackling this 👍 .

domenicsim1
domenicsim1 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@domenicsim1 domenicsim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy for this to be merged, thanks for doing it again in framework. Please squash merge with a conventional commit like feat: git trigger resource so it automatically picked up in the release notes for the next release.

@lourens-octopus lourens-octopus merged commit 96faef6 into main Dec 9, 2024
22 checks passed
@lourens-octopus lourens-octopus deleted the lourens/git-trigger branch December 9, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenicsim1 domenicsim1 domenicsim1 approved these changes

@geofflamrock geofflamrock geofflamrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lourens-octopus @geofflamrock @domenicsim1