feat: Add support for generic oidc accounts #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grace-rehn
commented
Dec 2, 2024
go.mod
Outdated
| @@ -3,7 +3,7 @@ module github.com/OctopusDeploy/terraform-provider-octopusdeploy | |||
| go 1.21 | |||
|
|
|||
| require ( | |||
| github.com/OctopusDeploy/go-octopusdeploy/v2 v2.60.0 | |||
| github.com/OctopusDeploy/go-octopusdeploy/v2 v2.62.3-0.20241202024636-075a4f06c227 | |||
There was a problem hiding this comment.
Use OctopusDeploy/go-octopusdeploy#288 for now.
Will update with the correct version once go client is merged after octopus server changes.
domenicsim1
approved these changes
Dec 5, 2024
| return | ||
| } | ||
|
|
||
| tflog.Debug(ctx, "Creating generic oidc account", map[string]interface{}{ |
There was a problem hiding this comment.
Fine to leave this as is but in the future, we can now use any instead of interface{} in Go. Makes the code easier to read.
| resource.TestCheckResourceAttr(resourceName, "audience", audience), | ||
| ), | ||
| ResourceName: resourceName, | ||
| }, |
There was a problem hiding this comment.
could you please include a 2nd TestStep so that we can also test update. It will basically be the same step, just with a slight change in the config, like a different description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to create and get a generic oidc account
[sc-98285]