feat: Add ability to disable tenants #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,8 +144,13 @@ func (t TenantSchema) GetResourceSchema() resourceSchema.Schema { | |||
| }, | |||
| "description": GetDescriptionResourceSchema("tenant"), | |||
| "id": GetIdResourceSchema(), | |||
| "name": GetNameResourceSchema(true), | |||
| "space_id": GetSpaceIdResourceSchema("tenant"), | |||
| "is_disabled": resourceSchema.BoolAttribute{ | |||
There was a problem hiding this comment.
Looking at the project resource schema the is_disabled schema has a boolplanmodifier.UseStateForUnknown() I think we need it here
UseStateForUnknown(): Copies a known prior state value into the planned value. Use this when it is known that an unconfigured value will remain the same after a resource update.
IsaacCalligeros95
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Can we update either the resource_tenant_migration_test.go or resource_tenant_test.go tests to update is_disabled and assert that is_disabled gets set. To run these locally you'll need to set some environment for testing_container_test.go or set the createSharedContainer flag to true. (Make sure your looking in the framework folder).
domenicsim1
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
octopusdeploy_tenant (Resource)andoctopusdeploy_tenants (Data Source)to includeis_disabled.#project-disabling-tenants
[sc-96619]