feat: machine proxy resource and data source

[domenicsim1]

Machine proxy resource and datasource.

resource "octopusdeploy_machine_proxy" "test_proxy" {
  space_id = "Spaces-1"
  name = "TestProxy"
  host = "192.168.0.1"
  username = "admin"
  password = "pass"
  port = 3000
}

data "octopusdeploy_machine_proxies" "prox" {
  skip = 0
  take = 10
  partial_name = "pietimeProxy"
}

closes #696

[denys-octopus]

Looks good 👍

[mjhilton]

LGTM, my only concern is ensuring that none of the operations allow a proxy password to be retrievable through the TF State. I assume this has been covered, it's just not super-clear from reading the code.

[mjhilton]

What does this do for TF state if, for example, the datasource was directly set as the value of an output? Do we do this form of ID'ing in other datasources?

[domenicsim1]

That is how terraform recommends handling state for data sources, we do it in all our data sources. This ID is internal for terraform, it uses it to understand and track when the data source changes.

[mjhilton]

I'm sure it's handled, but just for my clarity: if the user doesn't provide a SpaceId on the Datasource, will this state.SpaceID be automatically set to the default Space from the Provider config?

[domenicsim1]

yes, that happens inside the Go client, if the space ID is "" (go will not let it be nil) we will use the space provided on the provider, if one is not provided by the provider it will use default space, if you don't have a default space set it will error gracefully.

[mjhilton]

Eww :) do we have to? I assume so, but would love if TFP didn't need to concern itself with this detail.

[domenicsim1]

Same. At least its not exposed to user.