-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate users data source to tf framework #795
Conversation
docs/data-sources/users.md
Outdated
- `ids` (List of String) A filter to search by a list of IDs. | ||
- `skip` (Number) A filter to specify the number of items to skip in the response. | ||
- `space_id` (String) A Space ID to filter by. Will revert what is specified on the provider if not set. | ||
- `space_id` (String) The space ID associated with this user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think space_id
should be removed entirely since users aren't space-scoped but I've left it in for backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, good point. Lets mark it as deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, let mark the space_id
as deprecated as it does nothing and we will remove it in 1.0 release.
docs/data-sources/users.md
Outdated
- `ids` (List of String) A filter to search by a list of IDs. | ||
- `skip` (Number) A filter to specify the number of items to skip in the response. | ||
- `space_id` (String) A Space ID to filter by. Will revert what is specified on the provider if not set. | ||
- `space_id` (String) The space ID associated with this user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, good point. Lets mark it as deprecated.
TF Config
Pre-migration
Post-migration
Changes
password
has been removed. This was always an empty string before.is_requestor
now returns the correct value for the user runningterraform apply
.