-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy schema helper and add tests #759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benPearce1
requested review from
IsaacCalligeros95,
hnrkndrssn and
HuyPhanNguyen
and removed request for
IsaacCalligeros95,
hnrkndrssn and
HuyPhanNguyen
August 28, 2024 07:38
hnrkndrssn
reviewed
Aug 28, 2024
hnrkndrssn
reviewed
Aug 28, 2024
hnrkndrssn
reviewed
Aug 28, 2024
hnrkndrssn
reviewed
Aug 28, 2024
hnrkndrssn
reviewed
Aug 28, 2024
hnrkndrssn
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Removes the
util/schema.go
file and moves all schema functionality to theschemas
packageIntroduces an interface for all schema defintions:
EntitySchema
Implements that schema on all resource/datasource schemas
Adds a test in the ensure that all attributes are coming from the appropriate source schema package
e.g all attributes and nested attributes for a datasource come from
github.com/hashicorp/terraform-plugin-framework/datasource/schema
and vice-versa for resources