Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy schema helper and add tests #759

Merged
merged 26 commits into from
Aug 29, 2024
Merged

Tidy schema helper and add tests #759

merged 26 commits into from
Aug 29, 2024

Conversation

benPearce1
Copy link
Collaborator

@benPearce1 benPearce1 commented Aug 20, 2024

This PR does the following:
Removes the util/schema.go file and moves all schema functionality to the schemas package
Introduces an interface for all schema defintions: EntitySchema
Implements that schema on all resource/datasource schemas
Adds a test in the ensure that all attributes are coming from the appropriate source schema package
e.g all attributes and nested attributes for a datasource come from github.com/hashicorp/terraform-plugin-framework/datasource/schema and vice-versa for resources

@benPearce1 benPearce1 marked this pull request as ready for review August 28, 2024 07:38
@benPearce1 benPearce1 changed the title Bp/tidy schema helper Tidy schema helper and add tests Aug 28, 2024
@benPearce1 benPearce1 enabled auto-merge (squash) August 29, 2024 02:30
@benPearce1 benPearce1 merged commit 03ebf36 into main Aug 29, 2024
22 checks passed
@benPearce1 benPearce1 deleted the bp/tidy-schema-helper branch August 29, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants