Chore!: Fix data source lists should be read only #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacCalligeros95
requested review from
hnrkndrssn,
benPearce1 and
HuyPhanNguyen
benPearce1
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#706 made all data source return lists read-only. During the Terraform migration a couple of data sources included attributes that were optional, with List Nested Blocks this makes the whole block optional. This PR tidies up those changes.
As a part of this fix I compared changes between the latest docs on the datasource fix branch and this. There were some other schema changes that look unexpected but most of these are due to framework limitations and still include validation attributes making them required.