-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore!: Migrate script module resource #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just those pesky data source attributes changing from read-only to optional 😁
|
||
### Optional | ||
|
||
- `description` (String) The description of this script module. | ||
- `id` (String) The unique ID for this resource. | ||
- `space_id` (String) The space ID associated with this resource. | ||
- `script` (Block List) The script associated with this script module. (see [below for nested schema](#nestedblock--script)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still required at the validator level, just not the schema as Block Lists do not allow it. There's a number of resources with this problem which I'm planning on looking into this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally with migrate from sdk version, create, read/refresh, update, delete
Migrates Script module resource & datasource