Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore!: Migrate script module resource #712

Merged
merged 12 commits into from
Aug 12, 2024

Conversation

IsaacCalligeros95
Copy link
Collaborator

@IsaacCalligeros95 IsaacCalligeros95 commented Aug 5, 2024

Migrates Script module resource & datasource

@IsaacCalligeros95 IsaacCalligeros95 marked this pull request as ready for review August 6, 2024 02:04
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just those pesky data source attributes changing from read-only to optional 😁


### Optional

- `description` (String) The description of this script module.
- `id` (String) The unique ID for this resource.
- `space_id` (String) The space ID associated with this resource.
- `script` (Block List) The script associated with this script module. (see [below for nested schema](#nestedblock--script))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still required at the validator level, just not the schema as Block Lists do not allow it. There's a number of resources with this problem which I'm planning on looking into this week.

Copy link
Collaborator

@benPearce1 benPearce1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally with migrate from sdk version, create, read/refresh, update, delete

@IsaacCalligeros95 IsaacCalligeros95 merged commit 44acc60 into main Aug 12, 2024
22 checks passed
@IsaacCalligeros95 IsaacCalligeros95 deleted the isaac/script-module-migration branch August 12, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants