Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spaceID support environment #551

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

tothegills
Copy link
Collaborator

No description provided.

@tothegills tothegills self-assigned this Oct 16, 2023
@@ -23,7 +23,7 @@ func (c *Config) Client() (*client.Client, diag.Diagnostics) {
}

// This is intentional on the feature branch - Todo: remove when merging to main branch
proxyStr := "http://127.0.0.1:8866"
proxyStr := "http://172.21.224.1:8866"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this change and keep it local for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I forgot!

octopusdeploy/config.go Outdated Show resolved Hide resolved
@domenicsim1 domenicsim1 merged commit 02ef8bb into feature/spaceid-support Oct 16, 2023
1 of 3 checks passed
@domenicsim1 domenicsim1 deleted the tothegills/environment branch October 16, 2023 00:48
domenicsim1 pushed a commit that referenced this pull request Oct 23, 2023
* feat: spaceID support environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants