Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the plugin's version as part of the release creation process #18

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

kevjt
Copy link
Collaborator

@kevjt kevjt commented Sep 24, 2024

Background

The version string in plugin.yaml defines the Helm plugin's version. Previously, this string was not being updated properly during the release tagging process. As a result, the plugin version has remained at 0.0.1, despite the latest tag being 0.2.2.

Screenshot 2024-09-25 at 8 52 15 am

Results

This PR implements versioning commits to automate the process of keeping the plugin.yaml version in sync with the actual release version. Version tracking is managed through changesets.

Example Versioning Pull Request

#17

test

use Github token

missed one

now test with changeset

hardcode changeset remote branch for testing

revert testing
@@ -0,0 +1,13 @@
{
"name": "helm-migrate-values",
"version": "0.2.2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set this to be the same as the version on the latest tag that we have

@kevjt kevjt force-pushed the kevjt/improve-release-versioning branch from 245c41c to 9a05734 Compare September 24, 2024 23:00
@@ -1,5 +1,5 @@
name: "migrate-values"
version: "0.0.1"
version: "0.2.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated the version directly here because there won't be a changeset associated with this PR (no changes to the actual migrator functionality itself).

testing

Version Helm Plugin

Version Helm Plugin

revert
@kevjt kevjt force-pushed the kevjt/improve-release-versioning branch from b8a40d7 to 5461b46 Compare September 26, 2024 04:46
@kevjt kevjt merged commit d980ec6 into main Sep 26, 2024
1 check passed
@kevjt kevjt deleted the kevjt/improve-release-versioning branch September 26, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants