Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight logging tweaks #349

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Slight logging tweaks #349

merged 3 commits into from
Dec 1, 2024

Conversation

matt-richardson
Copy link
Contributor

Background

I noticed a few (super low priority) issues with these logs:

image

  • it's not including the build id as an attribute
  • it should be for, not or.

@matt-richardson matt-richardson self-assigned this Dec 1, 2024
@matt-richardson matt-richardson requested a review from a team as a code owner December 1, 2024 23:14
wlthomson
wlthomson approved these changes Dec 1, 2024
View reviewed changes
Copy link

@wlthomson wlthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug makes sense. Trusting your know how on the fix.

@matt-richardson matt-richardson enabled auto-merge (squash) December 1, 2024 23:20
@matt-richardson matt-richardson merged commit ee3aa63 into main Dec 1, 2024
3 checks passed
@matt-richardson matt-richardson deleted the mattr/logging-tweaks branch December 1, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlthomson wlthomson wlthomson approved these changes

Assignees

@matt-richardson matt-richardson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-richardson @wlthomson