Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log build id with metrics #348

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

matt-richardson
Copy link
Contributor

@matt-richardson matt-richardson commented Nov 30, 2024

Background

It's useful to know at the metrics level, which builds are related.

Results

Adds teamcity.build_promotion.id (which maps 1:1 with buildId) to the metrics emitted.

image

@matt-richardson matt-richardson self-assigned this Nov 30, 2024
@matt-richardson matt-richardson requested a review from a team as a code owner November 30, 2024 01:31
Copy link

@wlthomson wlthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 .

@matt-richardson matt-richardson enabled auto-merge (squash) December 1, 2024 22:05
@matt-richardson matt-richardson merged commit 107e6f4 into main Dec 1, 2024
3 checks passed
@matt-richardson matt-richardson deleted the mattr/rsb/include-build-id-on-metrics branch December 1, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants