Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract config settings pages to their own files #337

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

matt-richardson
Copy link
Contributor

Background

This is a really old change that I hadn't merged in - it extracts the front end code for different service types to their own files.

Results

No noticeable change, just better code structure.

@matt-richardson matt-richardson requested a review from a team as a code owner November 26, 2024 05:31
@matt-richardson matt-richardson self-assigned this Nov 26, 2024
Copy link

@akirayamamoto akirayamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking down seems to make it easier to maintain. I haven't compared the files.

@matt-richardson matt-richardson merged commit eac2d30 into main Nov 26, 2024
3 checks passed
@matt-richardson matt-richardson deleted the mattr/rsb/refactor-config-settings branch November 26, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants