Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Java 11 to Java 17 #195

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

matt-richardson
Copy link
Contributor

Background

Java 11 is EOL on 30 September. We need to upgrade

Results

This PR upgrades to Java 17.
This necessitated an upgrade to gradle too.

How to review this PR

Pre-requisites

  • I have considered informing or consulting the right people
  • I have considered appropriate testing for my change.

@matt-richardson matt-richardson self-assigned this Sep 27, 2023
@matt-richardson matt-richardson requested a review from a team September 27, 2023 23:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this is a generated file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It's a copy and paste from the reportportal PR, where it was auto-generated.

Copy link

@stevencl840 stevencl840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but looks good

@matt-richardson matt-richardson merged commit 9c70b99 into main Sep 28, 2023
1 check passed
@matt-richardson matt-richardson deleted the mattr/rsb/upgrade-java branch September 28, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants