Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test action against running Octopus Server #127

Merged
merged 14 commits into from
Dec 18, 2023

Conversation

geofflamrock
Copy link
Collaborator

@geofflamrock geofflamrock commented Dec 14, 2023

There are currently some tests that run on build that exercise the action against a mocked Octopus Server. These are helpful as they run quickly and can provide an indicator if something is wrong with the code. However these run on the code before it is compiled into the final javascript for the action, and don't run against a real Octopus Server so cannot give us the full confidence that a change won't break something for end users of the action.

This PR adds a new job to the build pipeline that uses the compiled action javascript (from the dist folder) against a real Octopus Server installation that is spun up for the job using docker compose. It performs a login using both API keys and OIDC and does a simple query using the octopus cli against the Server to ensure that the action works as expected.

Copy link

changeset-bot bot commented Dec 14, 2023

⚠️ No Changeset found

Latest commit: a0b7769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@geofflamrock geofflamrock marked this pull request as ready for review December 14, 2023 23:58
@geofflamrock geofflamrock requested a review from a team as a code owner December 14, 2023 23:58
@@ -60,10 +60,96 @@ jobs:
name: dist
path: dist/

test:
Copy link
Collaborator Author

@geofflamrock geofflamrock Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to adjust the branch protections to require integration tests job as well as this job

@geofflamrock geofflamrock changed the title Test action against running Octopu Server Test action against running Octopus Server Dec 15, 2023
Copy link

@mattocto mattocto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked this over, and at a high level, it seems fine. If there's something specific you actually wanted reviewed in detail then please find an extra reviewer for it :)

@geofflamrock geofflamrock merged commit e9c1e3f into main Dec 18, 2023
7 checks passed
@geofflamrock geofflamrock deleted the geoffl/test-dist-in-build branch December 18, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants