-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test action against running Octopus Server #127
Conversation
|
@@ -60,10 +60,96 @@ jobs: | |||
name: dist | |||
path: dist/ | |||
|
|||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to adjust the branch protections to require integration tests job as well as this job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked this over, and at a high level, it seems fine. If there's something specific you actually wanted reviewed in detail then please find an extra reviewer for it :)
There are currently some tests that run on build that exercise the action against a mocked Octopus Server. These are helpful as they run quickly and can provide an indicator if something is wrong with the code. However these run on the code before it is compiled into the final javascript for the action, and don't run against a real Octopus Server so cannot give us the full confidence that a change won't break something for end users of the action.
This PR adds a new job to the build pipeline that uses the compiled action javascript (from the
dist
folder) against a real Octopus Server installation that is spun up for the job using docker compose. It performs a login using both API keys and OIDC and does a simple query using the octopus cli against the Server to ensure that the action works as expected.