Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from base URL which causes a double slash in the final URL which short.io fails to parse #451

Open
wants to merge 3 commits into
base: release/v1
Choose a base branch
from

chore: Remove trailing slash from URL

476cd16
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Remove trailing slash from base URL which causes a double slash in the final URL which short.io fails to parse #451

chore: Remove trailing slash from URL
476cd16
Select commit
Loading
Failed to load commit list.
GitHub Actions / JEST Tests succeeded Mar 1, 2024 in 0s

13 passed, 0 failed and 0 skipped

Tests passed successfully

✅ reports/jest-junit.xml

13 tests were completed in 9s with 13 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
tests/main.test.ts 5✅ 8s
tests/octopusCLIVersionFetcher.test.ts 8✅ 3s

✅ tests/main.test.ts

installer
  ✅ fails to acquire a version of Octopus CLI
  ✅ fails to acquire a version of Octopus CLI
  ✅ acquires version 8.* of Octopus CLI
  ✅ acquires latest version of Octopus CLI
  ✅ acquires latest version of Octopus CLI

✅ tests/octopusCLIVersionFetcher.test.ts

OctopusCLIVersionFetcher tests
  ✅ Gets latest
  ✅ Fixed returns fixed version
  ✅ When version no exists
  ✅ Get latest minor
  ✅ Get latest patch
  ✅ When version spec if invalid
  ✅ Get latest major
  ✅ Get latest not pre-release