Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create page for git triggers #2559

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Create page for git triggers #2559

merged 1 commit into from
Nov 14, 2024

Conversation

lourens-octopus
Copy link
Contributor

Create page for git triggers

@lourens-octopus lourens-octopus requested a review from a team November 12, 2024 21:11
Copy link
Contributor

@geofflamrock geofflamrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, I've just left a few small thoughts and questions

pubDate: 2024-11-05
modDate: 2024-11-05
title: Git repository triggers
description: Git repository triggers allow you to automatically create a new release when a new commit is pushed to a Git repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we had chatted about separately, it might be good to have some sort of introduction to this page, this description reads pretty nicely so perhaps we can go with this for the moment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added


The versions used for those releases is guided by [release versioning](/docs/releases/release-versioning) under **Settings**. They will use the rules defined there.

A preview of the [lifecycle](/docs/releases/lifecycles) used by the selected channel is displayed. You can modify the [lifecycle's phases](/docs/releases/lifecycles/#Lifecycles-LifecyclePhases) to have a release created and deployed to selected environments whenever a new commit is pushed to the monitored repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can modify the lifecycle's phases to have a release created and deployed to selected environments whenever a new commit is pushed to the monitored repository.

The way this is phrased makes it sounds kind of like you can modify the lifecycle in place, perhaps we could add something about clicking on the relevant link to modify the lifecycle if required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added


| **Character** | **Description** | **Example** |
|---------------|-------------------------------------------|-----------------------------------------------------------------------------------------------------------------------|
| `*` | Matches multiple characters except `/` | File path pattern of `release/*` will match the file path `release/1.0.0` but not `release/1.0.0/hotfix1` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples look like they were taken from the Git protection rules and look more like branches, it might be good to make them look a bit more like file paths one might see in a repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


## History

The history section contains information about the last time the trigger was evaluated and the last release that was created by the trigger. By default, triggers are evaluated every three minutes and the results will be reported here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The history section contains information about the last time the trigger was evaluated and the last release that was created by the trigger. By default, triggers are evaluated every three minutes and the results will be reported here.
The history section contains information about the last time the trigger was evaluated and the last release that was created by the trigger. Triggers are evaluated every three minutes and the results will be reported here.

Having "By default" here makes it sound like its configurable which from memory it's not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@lourens-octopus lourens-octopus merged commit b18cb1f into main Nov 14, 2024
4 checks passed
@lourens-octopus lourens-octopus deleted the lourens/git-triggers branch November 14, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants