Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs on validation of oidc tokens and error response #2067

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

geofflamrock
Copy link
Contributor

@geofflamrock geofflamrock commented Nov 2, 2023

Docs for using OpenID Connect with the Octopus API were added in #2009. There were a couple of sections that were empty or had todos on them 😳:

  • Validation of identity tokens
  • Details of an error response to a token exchange request.

This PR fills those in. It also changes some of the "getting started" intro paragraphs to be a bit clearer.

Also adds in error response details
@geofflamrock geofflamrock changed the title Adds docs on validation of oidc tokens Adds docs on validation of oidc tokens and error response Nov 2, 2023
Copy link
Contributor

@mattocto mattocto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor grammatical change :)

@geofflamrock geofflamrock requested a review from mattocto November 3, 2023 02:16
Copy link
Contributor

@mattocto mattocto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geofflamrock geofflamrock merged commit bcaa740 into main Nov 3, 2023
3 checks passed
@geofflamrock geofflamrock deleted the geoffl/validating-oidc-tokens branch November 3, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants