Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dictionary-octopus.txt #2049

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Update dictionary-octopus.txt #2049

merged 1 commit into from
Oct 20, 2023

Conversation

tonykelly-octopus
Copy link
Contributor

Added keywords to dictionary list as per Bob's Slack message - https://octopusdeploy.slack.com/archives/C03UDS16R6G/p1697806413861879

Copy link
Contributor

@BobJWalker BobJWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's a shame we have to worry about capitalization.

@BobJWalker BobJWalker merged commit 5751cb8 into main Oct 20, 2023
3 checks passed
@BobJWalker BobJWalker deleted the tk/dictionary-additions branch October 20, 2023 15:21
@tonykelly-octopus
Copy link
Contributor Author

@BobJWalker I'm not sure if we do in the majority of scenarios (or at all - Steve Fenton will confirm when he's back on deck). If it is case sensitive, in the case of Runbooks / runbooks I figured they could both be correct (product feature vs a runbook) so I covered both bases.

@steve-fenton-octopus
Copy link
Contributor

Hey folks.

We only need to worry about adding the capitalized version if we're pretending something is a proper noun. It understands that all words can be capitalized at the start of a sentence, but with things like "Runbooks", if we want to say "this is a proper noun" and use it like "You can add a Runbook", then we do need to make that clear.

Otherwise, it would allow any word to be capitalized, which would be much worse :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants