Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicates the extension and CI word lists. #2044

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

steve-fenton-octopus
Copy link
Contributor

The word list has been moved into a simple text file - one entry per line.

Removing the settings seems to work - the VS Code extension responds to changes in the custom Octopus dictionary.

I've started with the "almost empty" dictionary so we can have the appropriate discussion around each term. I'd like to make sure we pick the right entry, for example MySql or MySQL, not both.

Copy link
Contributor

@tonykelly-octopus tonykelly-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steve-fenton-octopus steve-fenton-octopus merged commit 204ea6a into main Oct 19, 2023
3 checks passed
@steve-fenton-octopus steve-fenton-octopus deleted the sf/unified-cspell-config branch October 19, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants