Emit stats for the teamcity file share #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cailyoung
approved these changes
Feb 13, 2024
|
|
||
| return new StorageStatistics(totalCapacityInBytes, shareUsageInBytes); | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
How should this behave if we forget to configure the environment values above?
There was a problem hiding this comment.
it will return null, and then we'll get 0's coming out of it, which I think we could alert on.
I considered going 💥, but thought this was wiser
|
This pull request has been linked to Shortcut Story #46017: Configure disk space alert for TeamCity Production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to track and alert on teamcity storage account exhaustion.
But, we cant get it out from azure via the standard metrics pipeline (via sumo), as it's not available :(
This PR adds a few new metrics:
build_storage_total_capacitybuild_storage_used_capacitybuild_storage_available_capacityIt should be able to use managed identity to get these values, and needs these env vars to work:
AZURE_FILE_SHARE_RESOURCE_GROUP_NAMEAZURE_FILE_SHARE_STORAGE_ACCOUNT_NAMEAZURE_FILE_SHARE_SUBSCRIPTION_IDAZURE_FILE_SHARE_STORAGE_SHARE_NAME[sc-46017]