Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for nullable value types and enums #14

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Added support for nullable value types and enums #14

merged 1 commit into from
Sep 24, 2020

Conversation

droyad
Copy link
Contributor

@droyad droyad commented Sep 16, 2020

No description provided.

andrew-moore-octo
andrew-moore-octo approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@andrew-moore-octo andrew-moore-octo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 Couple of questions:

  • Do we need to handle arrays of enums?
  • Do we need to handle arrays of nullables?

@droyad
Copy link
Contributor Author

droyad commented Sep 16, 2020

Do we need to handle arrays of enums?
Do we need to handle arrays of nullables?

Right now, not that I can think of. I tried adding it and the converter structure stood in my way :/. Raised #15

@droyad droyad changed the base branch from ToObject to main September 24, 2020 02:22
@droyad droyad merged commit 9c9d718 into main Sep 24, 2020
@droyad droyad deleted the Enum branch September 24, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-moore-octo andrew-moore-octo andrew-moore-octo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droyad @andrew-moore-octo