Deprecate AzureRM - PowerShellContext #1394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
force-pushed
the
tmm/finish_azure_rm_deps
branch
from
1de47c9 to
637ce00
Compare
flin-8
reviewed
Jan 7, 2025
| @@ -11,6 +11,9 @@ $OctopusAzureEnvironment = $OctopusParameters["Octopus.Action.Azure.Environment" | |||
| $OctopusOpenIdJwt = $OctopusParameters["Octopus.OpenIdConnect.Jwt"] | |||
| $OctopusUseOidc = ![string]::IsNullOrEmpty($OctopusOpenIdJwt) | |||
|
|
|||
| ## The script is passed the following parameters. | |||
There was a problem hiding this comment.
Which version of Server are you targeting? I've made a breaking change in Calamari (#1405) so you'll need to target a 28.x.x branch if this is going to 2024.4
There was a problem hiding this comment.
I think it'll need to be 2025.1 - so main is fine (i.e. I don't really want to push this out to on-prem).
Aside from that - the feature toggle should probably be flipped to prevent the usage of AzureRM by default (but with an escape hatch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AzureRM deprecation flag is required to be included in the AzurePowershellContext.ps1 to show a warning if users
are still using AzureRM module (Rather than Azure CLI).
This feature flag means users are presented with a warning atm - which will become an error at some point in the future.
The script update matches that performed in the prior AzureContext.ps1
[sc-74652]