Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Fighting Option #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fire Fighting Option #9

wants to merge 6 commits into from

Conversation

wlbragg
Copy link

@wlbragg wlbragg commented Oct 28, 2024

Adds complete, user selectable, fire fighting tank and systems.

@wlbragg
Copy link
Author

wlbragg commented Oct 28, 2024

@Octal450
This is mostly finished. The only thing I know that is left to complete is to convert the nasal portion to IS style. I wanted to get the entire work over to this repository for review and any comments. I have a few questions about the IS style format. I used autopilot filters for the system control vs JSB functions so it is more portable to YASim aircraft I plan to update. The entire system, tank and panels can be selected or not by enabling it in the Utilities/Firetank GUI. There are several properties initialised in the -set file that don't really even need to be initialized. I'm talking about the filter derived properties. Do we want to remove those? The other initialised properties such as for switch states that are currently in the -set files, are those what you want removed from there and added to a nasal IS init type style or the PTS style init, or both where applicable? It's not really clear what is needed, maybe vs me asking, you can review and direct what you want changed.

@wlbragg
Copy link
Author

wlbragg commented Oct 28, 2024

One more thing, I don't know how versed you are with delta-time. Currently the distribution dial and that system is a pseudo time based retardant drop. Meaning, unless we incorporate delta-time it is really just a rough estimate of real timing control. I don't know that it really matters though as the Wildfire code doesn't have any mechanism for adjusting the amount of retardant that is dumped on the ground. So at best the distribution dial is really only changing the amount of time the door is open and how much of the load is released in that time, but has no basis for reality as to the volume that actually affects the fire on the ground. What it does do for the user is allow up to 8, 8 second drops per tank fill. I did not restrict filling the tank to being on the ground, We could do that, generally I don't but some designers do thing like restricting resupplies to real life restrictions. Also, knowhere do I mention the the Wildfire addon is required to "effectively" use this system, although it can be used without the addon, it just won't really do anything.

@wlbragg
Copy link
Author

wlbragg commented Oct 28, 2024

@Octal450
Beware, there is quite a bit of refactoring after the initial commit, so make sure you review on the last commits of any system or files.
Once this is finished I will have a roadmap for doing the DC-10 and plan to add the system to it as well.

@wlbragg
Copy link
Author

wlbragg commented Oct 28, 2024

Oh, one more thing, I go all in on the eye candy sometimes and so all the panel indicators have procedural lighting. If you like it, I can update "ALL" the other lamps in all the other panels in the aircraft to also have the procedural glowing style lamps. I really like the effect, especially at night. Granted I don't think they use the fire tankers at night, but the rest of the panels would benefit, your call.

@wlbragg
Copy link
Author

wlbragg commented Oct 28, 2024

FYI: Drop procedure...

Select Enable in the GUI
Select Water or default for Red Retardant
Fill retardant tank
Power the system with Power Switch
Dial the distribution desired
Arm the system with the Arm Switch.
Flip the drop switch to release retardant or Shift-k

@wlbragg
Copy link
Author

wlbragg commented Oct 28, 2024

There are no designed faults, The System Pressure Low and Salvo Pressure Low I guessed needed the system to be "armed" in order to extinguish the lamps. Same with the Vent Door Open, vent to stay closed until armed.. Space Open lamp, to best info I could find, was like a tank level indicator, If the tank is not full that light is on. Fluid Det (detection) lamp is on if there is no usable retardant in the tank. The Fault lamp is currently only tied to the test lamp button. I've never worked with designed fault systems, it's something I would like to learn though, so if you want to add some faults to the system, I will observe and see what it is that you do.

@Octal450
Copy link
Owner

Thanks, I'll check this out later tonight!

Josh

@wlbragg
Copy link
Author

wlbragg commented Oct 31, 2024

FYI: I converted the nasal tankoperations.nas file to more of an IS style format. I don't have really have a "reset" function yet, but it can be added easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants