Insulating complexity in the parameter generator

Ocramius · Mar 12, 2014 · eaaf10f · eaaf10f
1 parent b6b90f1
commit eaaf10f
Showing 1 changed file with 20 additions and 7 deletions.
diff --git a/src/ProxyManager/Generator/ParameterGenerator.php b/src/ProxyManager/Generator/ParameterGenerator.php
@@ -50,13 +50,7 @@ public static function fromReflection(ParameterReflection $reflectionParameter)
             $param->setType($type);
         }
 
-        if ($reflectionParameter->isOptional()) {
-            try {
-                $param->setDefaultValue($reflectionParameter->getDefaultValue());
-            } catch (ReflectionException $e) {
-                $param->setDefaultValue(null);
-            }
-        }
+        self::setOptionalParameter($param, $reflectionParameter);
 
         $param->setPassedByReference($reflectionParameter->isPassedByReference());
 
@@ -135,4 +129,23 @@ private function getGeneratedType()
 
         return '\\' . trim($this->type, '\\') . ' ';
     }
+
+    /**
+     * Set the default value for a parameter (if it is optional)
+     *
+     * @param ZendParameterGenerator $parameterGenerator
+     * @param ParameterReflection    $reflectionParameter
+     */
+    private static function setOptionalParameter(
+        ZendParameterGenerator $parameterGenerator,
+        ParameterReflection $reflectionParameter
+    ) {
+        if ($reflectionParameter->isOptional()) {
+            try {
+                $parameterGenerator->setDefaultValue($reflectionParameter->getDefaultValue());
+            } catch (ReflectionException $e) {
+                $parameterGenerator->setDefaultValue(null);
+            }
+        }
+    }
 }