fix voiceChannelLeave event on no cache #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello,
when caching is disabled, the
voiceChannelLeave
event does not emit at all. that's because the event is only emitted if the cached valueoldChannel
is defined. instead, I propose to directly check if thestate.channelID
is null, so the event doesn't have to depend on whether the old voice state and the old channel are cached.when the old channel is not cached, it will pass
null
as the value for theoldChannel
event parameter, so I updated its type accordinglythanks