-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joss paper updates #48
Conversation
…e important for near-future plastic concentration map predictions.
Good suggestion! Co-authored-by: Erik van Sebille <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 8 8
Lines 715 715
=======================================
Hits 478 478
Misses 237 237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the acknowledgements, 'OceanParcels team', or 'Lagrangian Ocean Analysis team'?
'Lagrangian Ocean Analysis team at Utrecht University'? |
Co-authored-by: Erik van Sebille <[email protected]>
…exibility of the kernels. Perhaps the first sentence should go to the prior paragraph, and we start this paragraph on this 'However, due to ...' sentence
for more information, see https://pre-commit.ci
Updates to the JOSS paper based on reviewer comments.