Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joss paper updates #48

Merged
merged 13 commits into from
Sep 5, 2024
Merged

Joss paper updates #48

merged 13 commits into from
Sep 5, 2024

Conversation

michaeldenes
Copy link
Member

Updates to the JOSS paper based on reviewer comments.

docs/paper/paper.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.85%. Comparing base (c4c786b) to head (2f33399).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files           8        8           
  Lines         715      715           
=======================================
  Hits          478      478           
  Misses        237      237           
Flag Coverage Δ
unit-tests 66.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@michaeldenes michaeldenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the acknowledgements, 'OceanParcels team', or 'Lagrangian Ocean Analysis team'?

@michaeldenes michaeldenes marked this pull request as ready for review September 4, 2024 13:03
@erikvansebille
Copy link
Member

In the acknowledgements, 'OceanParcels team', or 'Lagrangian Ocean Analysis team'?

'Lagrangian Ocean Analysis team at Utrecht University'?

docs/paper/paper.md Outdated Show resolved Hide resolved
michaeldenes and others added 4 commits September 4, 2024 17:32
Co-authored-by: Erik van Sebille <[email protected]>
…exibility of the kernels. Perhaps the first sentence should go to the prior paragraph, and we start this paragraph on this 'However, due to ...' sentence
@michaeldenes michaeldenes merged commit fa1c4e6 into main Sep 5, 2024
5 checks passed
@michaeldenes michaeldenes deleted the joss_paper_updates branch September 5, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants