Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Podspec] remove version for FBSDK #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

markedwardmurray
Copy link

@markedwardmurray markedwardmurray commented Jun 1, 2016

Hey guys!

Great library, thank you for sharing it. We've been using it in www.getsquad.co and realized the FBSDK dependency is a version behind. It seems to run fine for our purposes on 4.12.0

Cheers!
~Mark

@RobertBiehl
Copy link

👍

@onomated
Copy link

👍 Looks good for v4.13.0 as well

@markedwardmurray markedwardmurray changed the title [Podspec] increment dependency to FBSDK v4.12.0 [Podspec] increment dependency to FBSDK v4.13.1 Jun 27, 2016
@markedwardmurray markedwardmurray changed the title [Podspec] increment dependency to FBSDK v4.13.1 [Podspec] increment dependency to FBSDK v4.12.0 Jun 27, 2016
@markedwardmurray markedwardmurray changed the title [Podspec] increment dependency to FBSDK v4.12.0 [Podspec] increment dependency to FBSDK v4.13.1 Jun 27, 2016
@markedwardmurray
Copy link
Author

(sorry for the notification spam for anyone following, I had an issue with FB Login that I had to diagnose)

@anatha
Copy link

anatha commented Jul 20, 2016

An important pull request! 👍
Facebook fixed a bug that caused apps to crash due to a nil _sessionID on 4.13.1
We cannot upgrade to 4.13.1 without this pull request...

@markedwardmurray
Copy link
Author

hey @anatha if you haven't already point your Podfile to install from this fork (or your own) so you can move forward with 4.13.1

@anatha
Copy link

anatha commented Jul 21, 2016

Wasn't aware that this was an option - thanks @markedwardmurray!

@markedwardmurray markedwardmurray changed the title [Podspec] increment dependency to FBSDK v4.13.1 [Podspec] remove version for FBSDK Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants