Fixing crash in player list. Also bumping version.

Oarcinae · Oct 23, 2024 · d891f75 · d891f75
1 parent ef16cd0
commit d891f75
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -1,4 +1,9 @@
 ---------------------------------------------------------------------------------------------------
+Version: 2.1.1
+Date: 2024-10-23
+  Bugfixes:
+    - Fix a crash when clicking on player location in player list.
+---------------------------------------------------------------------------------------------------
 Version: 2.1.0
 Date: 2024-10-22
   Major Features:

diff --git a/info.json b/info.json
@@ -1,6 +1,6 @@
 {
   "name": "oarc-mod",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "factorio_version": "2.0",
   "title": "Oarc Multiplayer Spawn",
   "author": "Oarcinae",

diff --git a/lib/gui_tabs/player_list.lua b/lib/gui_tabs/player_list.lua
@@ -123,6 +123,15 @@ function PlayerListTabGuiClick(event)
         local player_name = tags.player_name --[[@as string]]
         local target_player = game.players[player_name]
 
-        player.set_controller{type = defines.controllers.remote, position = target_player.character.position, surface = target_player.character.surface}
+        if (target_player == nil) then
+            player.print({"oarc-player-not-found", player_name})
+            return
+        end
+
+        if (target_player.character) then
+            player.set_controller{type = defines.controllers.remote, position = target_player.character.position, surface = target_player.character.surface}
+        else
+            player.set_controller{type = defines.controllers.remote, position = target_player.position, surface = target_player.surface}
+        end
     end
 end