PR modularize code #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge https://github.com/rezasp/joomscan into modularize_code
….pl, breaks windows compatibility
modifies code to avoid global variables $amtf, $adming
removes obsolete core/*pl files
adds .gitignore
adds Report.pm, fixes import in VulnDB
todo check for different behaviour
|
Hi StPanning, It seems that your changes require the current directory |
|
for now you have to be in the sam directory as joomscan.pl this is the reason for issue #25 because this will fix this. I will implement it, as soon as my changes are approved so far. |
|
Hello, regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves code in modules and functions
makes variables private (my... ) where possible
uses 'use ...' directive instead of 'do...'