Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert no. 28: Uncontrolled data used in path expression #932

Closed
wants to merge 1 commit into from
Closed

Fix code scanning alert no. 28: Uncontrolled data used in path expression #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions nettacker/api/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,17 @@ def get_file(filename):
Returns:
content of the file or abort(404)
"""
if not os.path.normpath(filename).startswith(str(Config.path.web_static_dir)):
base_path = str(Config.path.web_static_dir)
fullpath = os.path.normpath(os.path.join(base_path, filename))
if not fullpath.startswith(base_path):
abort(404)
try:
return open(filename, "rb").read()
return open(fullpath, "rb").read()
except ValueError:
abort(404)
except IOError:
abort(404)


def api_key_is_valid(app, flask_request):
"""
check the validity of API key
Expand Down
Loading