Add tests on PR #174
Merged
Add tests on PR #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll self-merge this too so that the automated tests get into the WIP branch. I'll also merge the |
leewujung
merged commit 9883e92
into
OSOceanAcoustics:brandynlucca-WIP-refactoring
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a pretty messy PR and may be closed and re-opened multiple times to see how things run.
@brandynlucca : Note to simplify this I actually made the following changes to
requirements.txt:requirements.txtscipynb_conda_kernels, which is NOT a pip packageUnpinning everything is potentially risky and we may run into things breaking down the line (see #104), but my thought is that we can add any pinning back if needed -- usually we don't pin things unless the newer version has some compatibility problems or would require significant code changes (like pandas=2.0 introduced quite a bit of changes that broke many packages for some time).