Add support for help_menu
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update default with a custom help_menu example.
Add `help_menu` to template to allow the role to setup custom help menu elements.
|
We have to update the test cases for this. I'm able to edit this pull request, and am happy to do so if you need. Just let me know if you want me to update the tests or if you can take care of it. |
|
Hi Jeff,
Sorry for the lack of updates, haven't found the time to fix the test yet
but I will do it as soon as possible.
Regards,
B
…On Tue, Nov 14, 2023, 16:15 Jeff Ohrstrom ***@***.***> wrote:
We have to update the test cases for this. I'm able to edit this pull
request, and am happy to do so if you need. Just let me know if you want me
to update the tests or if you can take care of it.
—
Reply to this email directly, view it on GitHub
<#221 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJDJ34SQLVNA4CSRJADWGTYEODJ3AVCNFSM6AAAAAA7F3ZM3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGQZTANZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No issues on latency and there's no rush from my side. Just let me know either way. |
|
Tests are failing because of the text fixtures being tested against. Here's a diff you can apply to get the tests to pass (it's just a newline on one of the test files) |
johrstrom
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the template to include support for the
help_menuelement.Update defaults with an example taken from the official documentation.