Files busy signal #3973
Files busy signal #3973
Conversation
| @@ -10,6 +10,7 @@ const EVENTNAME = { | |||
| }; | |||
|
|
|||
| const CONTENTID = '#directory-contents'; | |||
| const BUSYID = '#tloading-spinner'; | |||
There was a problem hiding this comment.
I know we use hyphens in other places, but we're trying to enforce snake_case Ids now.
| @@ -24,6 +24,13 @@ | |||
| <tbody> | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| <div class="text-center text-primary" style="display:none" id="tloading-spinner"> | |||
There was a problem hiding this comment.
Instead of inline styles, we should be using the class d-none. inline styles are a CSP violation (or at least will be at some point) so we should avoid using them.
So I think instead of the jQuery API for hide & show, we should just edit the classList in plain javascript.
// API to add to remove from the classList
document.getElementById('directory-contents').classList.remove('d-none');
// API to add to the classList
document.getElementById('directory-contents').classList.add('d-none');
|
|
||
| <div class="text-center text-primary" style="display:none" id="tloading-spinner"> | ||
| <div class="spinner-border"> | ||
| <span class="visually-hidden">Loading...</span> |
There was a problem hiding this comment.
Never seen visually-hidden before, but we tend to use sr-only.
|
Not sure why tests fail, but clearly the test is moving too fast for the system to actually remove the file. Putting a sleep here tends to make the test pass for me. --- a/apps/dashboard/test/system/remote_files_test.rb
+++ b/apps/dashboard/test/system/remote_files_test.rb
@@ -279,6 +279,9 @@ class RemoteFilesTest < ApplicationSystemTestCase
find('#delete-btn').click
find('button.swal2-confirm').click
+ # sleep for the file to actually be removed.
+ sleep 1
+
# verify app dir deleted according to UI
assert_no_selector 'tbody a', exact_text: 'app', wait: 10
assert_no_selector 'tbody a', exact_text: 'foo.txt', wait: 10 |
| @@ -0,0 +1,5 @@ | |||
| <div class="text-center text-primary d-none p-500" id="tloading_spinner"> | |||
There was a problem hiding this comment.
What is the p-500 class here? I can't seem to find a definition for it./
There was a problem hiding this comment.
Whoops I was messing around with the styling and forgot to delete that.
|
Thanks! |
Fixes #1189