Lint a random file #3946
Merged
Lint a random file #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osc-bot
force-pushed
the
osc-bot/random-linted-file
branch
from
79ddc58 to
e0eb33b
Compare
johrstrom
reviewed
Nov 13, 2024
| @@ -27,9 +29,8 @@ def socket | |||
| # Delete the socket from the file system | |||
| def delete | |||
| @socket.delete | |||
| rescue | |||
| $stderr.puts "Unable to delete socket file at #{socket}" | |||
| rescue StandardError | |||
There was a problem hiding this comment.
I don't think file Errors are StandardErrors so I can't pull this in as is. I.e., this wouldn't actually get rescued.
There was a problem hiding this comment.
Actually I'm wrong. This catches file errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of linting a random file.