Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM - Update fixed checkbox when environment variable changes #3842

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ashton22305
Copy link
Contributor

Work on #3743

Updates the information of the fixed checkbox when the environment variable changes so that it remains possible to fix/unfix it.

@johrstrom
Copy link
Contributor

It's going to take me a second to look this over because I didn't write it. Plus fixing environment variables seems to be working for me, so it's not clear what this solves.

@ashton22305
Copy link
Contributor Author

fixing environment variables seems to be working for me, so it's not clear what this solves.

Because the name (and id) of the attribute changes whenever the user changes the name of the environment variable, the ability to fix/unfix breaks when the name of the environment variable is changed. This is especially important to consider when creating a new environment variable.

@johrstrom
Copy link
Contributor

fixing environment variables seems to be working for me, so it's not clear what this solves.

Because the name (and id) of the attribute changes whenever the user changes the name of the environment variable, the ability to fix/unfix breaks when the name of the environment variable is changed. This is especially important to consider when creating a new environment variable.

Got it, thank you! Yea I only tried to use them - I did not try to rename them. I'll look at it further.

@johrstrom johrstrom merged commit eb9ce2e into master Oct 9, 2024
26 checks passed
@johrstrom johrstrom deleted the update-fixed-checkbox branch October 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants