Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure a little to get a better layout #3793

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

johrstrom
Copy link
Contributor

This restructures the projects#show page a little to get a better/columnar layout.

Copy link
Contributor

@ashton22305 ashton22305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the screen is a certain width, the tables will start to escape the cards that contain them.
image

@johrstrom
Copy link
Contributor Author

Thanks! I can take a look.

@johrstrom
Copy link
Contributor Author

When the screen is a certain width, the tables will start to escape the cards that contain them.

My feeling is to kind of defer it. If I look at what a tablet/phone does its OK. There's no actual device of this size/width. I feel like it's only us/developers who will encounter this when they open their dev tools to be that wide.

Copy link
Contributor

@ashton22305 ashton22305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, this looks good to me!

@johrstrom johrstrom merged commit 972a03b into master Sep 23, 2024
46 of 50 checks passed
@johrstrom johrstrom deleted the better-job-layout branch September 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants